Viewing 2 posts - 1 through 2 (of 2 total)
  • Author
    Posts
  • #5394

    pline
    Participant
    Points: 6

    I recently installed this plugin in one of our projects and I’ve run into a few issues with it. After some debugging I made a few hotfixes myself, but decided to bring this to attention.

    1) Download link on e-mail not working

    This seems to happen, because WordPress automatically checks if the content you’re inserting on the database (via $wpdb->insert) actually fits whithin the varchar limit. Since the generated link for the download was larger than the 200 limit from the file_url column, wordpress wouldn’t insert anything on the table. The download link checks if the link is still valid, but since nothing is inserted, it can’t find anything and redirects the user to the expire page.

    I simply changed file_url to a much larger limit and everything worked fine.

    2) Multiple forms on the same page

    I’m not sure if this is a bug or if it was intended to be that way, but the plugin doesn’t work if you insert multiple downloads on the same page. I made a few changes in the code, because I really needed this feature for this project.

    file: ../email-to-download/ed-files/classes/class.shortcodes.php:26
    old: @include_once ED_FILES_DIR . “/templates/{$style}.php”;
    new: @include ED_FILES_DIR . “/templates/{$style}.php”;

    file: ../email-to-download/ed-files/assets/js/ed-front.js:54
    old:

    var html = $('.ed_pop_wrap').html();
    $( '.ed_pop a' ).click(function(e) {
      e.preventDefault();
      $.colorbox({
        width: 800,
        height: 600,
        html: html
      });
      $.colorbox.resize();
      popupRun = true;
      return false;
    })

    new:

    $( '.ed_pop a' ).click(function(e) {
      var html = $(this).closest('.ed_pop').next('.ed_pop_wrap').html();
      e.preventDefault();
      $.colorbox({
        width: 800,
        height: 600,
        html: html
      });
      $.colorbox.resize();
      popupRun = true;
      return false;
    })

    3) Localization not working

    file: ../email-to-download/email-to-download.php:10
    old: Text Domain: etd
    new: Text Domain: email-to-download
    (I’m not sure if this was necessary, but I changed it just to make sure)

    file: ../email-to-download/email-to-download.php:396
    old: load_plugin_textdomain( ’email-to-download’, FALSE, ED_PLUGIN_URI . ‘/languages’ );
    new: load_plugin_textdomain( ’email-to-download’, FALSE, dirname( plugin_basename( __FILE__ ) ) . ‘/languages’ );
    The load_plugin_textdomain requires a relative path as the third argument, instead of the full path that was given.

    Other than that, it’s a great plugin and it really helped our company!

    #5398

    Sushi
    Staff
    Points: 199

    Hello @pline

    Thank you very very much for escalating the issues with us, pretty much appreciated. I am definitely sending this to our developer so that he can investigate.

    We are already working on to introduce new features, so that a minor version is released today. But I can ensure that another version with these bug fixes will be released in next week.

    Our developer is currently away in the weekend, but as soon he is online at Monday he will work on these.

    Thanks again, if you think any more feature that can improve the plugin, please let us know 🙂

    Regards,
    – Sushi

Viewing 2 posts - 1 through 2 (of 2 total)

You must be logged in to reply to this topic.